Added the script to run integration tests in spi.

[elopio]

No description provided.

[zyga]

did you mean to have no space between" and EXIT?

[elopio]

nop, that was a copy & paste error. Thanks for catching that.

[zyga]

Do you need to build anything that might be on the system already (snappy/snapd)? Perhaps $GOPATH/bin:$PATH would be better so that you always get the locally built versions?

[elopio]

I don't need that atm, but it seems better to avoid future problems.

[zyga]

Apart from the two questions above, looks good to me

[elopio]

Thanks for the review @zyga. I pushed both changes.

[chipaca]

is the lack of -e on purpose?

[elopio]

Yes, if it exits before filling the result.json we get no information about what happened.

[chipaca]

One stray " in the tests output and the json asplodes. Maybe something like
python3 -c 'import os,json; for k, v in {"output": "output_print(json.dumps({"output": "{output_paste}".format(**os.environ)}))'
(etc.). You could also use jq's env function.

[elopio]

with pastebinit we either get an error because the file doesn't exist, or a link. Both cases generate a correct json. So, wouldn't it be simpler and clearer to paste also the summary so the four fields are links?

[chipaca]

Your call, I think.

[niemeyer]

with pastebinit we either get an error because the file doesn't exist, or a link.

So the only possible outcome of that fiddly Python application that involves HTTP, XML configuration files, and HTML processing with regular expressions (!), is that it outputs a link or a single known error, and never any quotes? Doesn't seem very plausible.

Why not taking @chipaca's feedback and addressing the problem? Seems so easy..

[elopio]

@niemeyer unless I misunderstood, @chipaca's proposal doesn't save us from using pastebinit.
I hate we have to use pastebinit. What I would like is for SPI to collect all the files we put in a well-known directory and upload them to a permanent storage that we can then consume from jenkins. But well, they told me to use pastebinit instead. 😞
So, between using bash + pastebinit and using bash + pastebinit + python, I prefer the one with less things.

Now, you raise a good point. I didn't take into account that pastebinit can fail if the server is down or something. And that error could include quotes. So I'll get to implement @chipaca's wisdom.

[niemeyer]

Thanks! That's the only point I was raising.. or actually, @chipaca was raising.. I just emphasized it. Ensuring all these variables are properly format should be trivial enough.

[niemeyer]

This is open for a month, and silent for a week. I'm closing it for the time being.. please feel free to reopen it when there is interest on the change again.