snap: show last refresh time #2394

mvo5 · Dec 1, 2016

Build on top of #2384

zyga · Dec 1, 2016

Looks good to me, a few minor questions. Feel free to merge if irrelevant or fixed.

❤️

Since apps cannot have any nasty characters I was wondering why would we be quoting that. I don't mind them quoted, just curious.

Why kB but MB? 2**10 vs 10 ** 3 aside, shouldn't those be uniformly capitalised?

niemeyer · Dec 1, 2016

LGTM, we should probably just respect the "refresh" terminology here.

niemeyer · Dec 1, 2016

@zyga Note all of these points are actually about the underlying #2384.

niemeyer · Dec 3, 2016

@mvo5 conflict here.

mvo5 changed the title from snap: show last update time to snap: show last refresh time Dec 5, 2016

@@ -54,7 +54,7 @@ type Snap struct {
          	Prices      map[string]float64 `json:"prices"`
          	Screenshots []Screenshot       `json:"screenshots"`
-        -	Channels map[string]*snap.Ref `json:"channels"`
+        +	Channels map[string]*snap.ChannelSnapInfo `json:"channels"`

+        +			for i, a := range both.Apps {
+        +				apps[i] = a.Name
+        +			}
+        +			fmt.Fprintf(w, "apps:\t[%s]\n", strutil.Quoted(apps))

@@ -47,6 +48,18 @@ func MakeRandomString(length int) string {
          	return out
          }
+        +// Convert the given size in btes to a readable string
+        +func SizeToStr(size int64) string {
+        +	suffixes := []string{"B", "kB", "MB", "GB", "TB", "PB", "EB"}

snapcore/snapd