Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Copied the list flag from gocheck. #242
Conversation
|
mmm IMO we don't need to get this far, this way we are going to list the tests inside a running testbed, and for that we need to build it and wait for it to boot. Maybe it would be easier to list them from the host, after the binary has been built in main.go, what do you think? |
fgimenez
referenced this pull request
Dec 14, 2015
Closed
Reverted the change that puts common test commands in the init. #241
|
|
|
Folks, I don't have enough context for these changes, but it sounds like there's some pending conversation from a month ago. Can you please sync up with each other and report back on your understanding of the way forward here? |
|
This is open for a month, and silent for a week. I'm closing it for the time being.. please feel free to reopen it when there is interest on the change again. |
niemeyer
closed this
Jan 12, 2016
elopio
reopened this
Mar 16, 2016
|
I resurrected this hacky PR because @plars still needs it and Gustavo didn't reply in go-check/check#73 (comment) |
|
+1 this is needed by some of my PRs that are waiting |
|
retest this please |
|
merge this please |
elopio commentedDec 9, 2015
Because gocheck doesn't let us extend the results reporter, we are doing a hacky solution to overwrite the output. This means that every time we need a new flag from gocheck, we need to copy it.
I'm starting to work on the upstream change to report subunit results, but that's not easy to do in go check. The certification team needs the list command, so I'm going with the quick solution while we finish the correct one.