Copied the list flag from gocheck. #242

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
4 participants
Member

elopio commented Dec 9, 2015

Because gocheck doesn't let us extend the results reporter, we are doing a hacky solution to overwrite the output. This means that every time we need a new flag from gocheck, we need to copy it.
I'm starting to work on the upstream change to report subunit results, but that's not easy to do in go check. The certification team needs the list command, so I'm going with the quick solution while we finish the correct one.

Contributor

fgimenez commented Dec 14, 2015

mmm IMO we don't need to get this far, this way we are going to list the tests inside a running testbed, and for that we need to build it and wait for it to boot. Maybe it would be easier to list them from the host, after the binary has been built in main.go, what do you think?

Contributor

fgimenez commented Dec 14, 2015

👍 this works too from the host, but you need to build manually the binary and then call it with -gocheck.list, sorry for not getting that before. Do you think that we sould add a list script? something like

go test -c ./integration-tests/tests -o ./integration-tests/bin/integration.test && ./integration-tests/bin/integration.test -gocheck.list

Contributor

niemeyer commented Jan 5, 2016

Folks, I don't have enough context for these changes, but it sounds like there's some pending conversation from a month ago. Can you please sync up with each other and report back on your understanding of the way forward here?

Contributor

niemeyer commented Jan 12, 2016

This is open for a month, and silent for a week. I'm closing it for the time being.. please feel free to reopen it when there is interest on the change again.

@niemeyer niemeyer closed this Jan 12, 2016

@elopio elopio reopened this Mar 16, 2016

Member

elopio commented Mar 16, 2016

I resurrected this hacky PR because @plars still needs it and Gustavo didn't reply in go-check/check#73 (comment)

Contributor

plars commented Mar 16, 2016

+1 this is needed by some of my PRs that are waiting

Member

elopio commented Mar 17, 2016

retest this please

Member

elopio commented Mar 17, 2016

merge this please

elopio added a commit that referenced this pull request Mar 17, 2016

Merge pull request #242 from elopio/gocheck_list
Copied the list flag from gocheck.

@elopio elopio merged commit 7db65ec into snapcore:master Mar 17, 2016

2 of 7 checks passed

autopkgtest No test results found.
Details
merge No test results found.
Details
Integration tests Started
Details
builddeb Build triggered. sha1 is merged.
Details
default Build started sha1 is merged.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 71.267%
Details

@elopio elopio deleted the elopio:gocheck_list branch Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment