tests: run all snap-confine tests in c-unit-tests task #2433

Merged
merged 15 commits into from Jan 12, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Dec 8, 2016

This fixes older snap-confine tests. They got to bit-rot a little and required some changes:

  • snap-confine relies on having SNAP_NAME set.
  • to run /bin/true on i386 you need 32bit variants of some syscalls

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

zyga added some commits Dec 8, 2016

tests: run all snap-confine tests in c-unit-tests task
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

mvo5 approved these changes Jan 2, 2017

Yay!

zyga added some commits Jan 2, 2017

cmd/snap-confine: re-enable older tests
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: show verbose failures from older snap-confine tests
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: fix path of the debug log
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: set SNAP_NAME for legacy snap-confine tests
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: use $(srcdir) to support out-of-tree builds
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: HACK, build snap-confine before running the test suite
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
cmd/snap-confine: add extra syscalls for snap-confine to self-test
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
cmd/snap-confine: add i386 specific syscalls
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
tests: show tail of kern.log when c-unit-tests fail
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
cmd/snap-confine/tests: add i386 syscalls required for true
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Thanks for working on this! LGTM

Contributor

zyga commented Jan 12, 2017

FYI: while debugging 14.04 test failure issues we realized that there are two separate things that were broken. Our PPA contained an old version of libseccomp that unfortunately sorted as newer due to version mangling in the PPA. In addition the nocheck tests in debian/rules were incorrect or missing which prevented the package from building. The first issue was fixed directly by removing the offending package. The second issue is being addressed here #2567 and needs to be merged into the 14.04 release branch once it lands in master.

@zyga zyga merged commit 9fd74c1 into snapcore:master Jan 12, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:snap-confine-older-tests branch Jan 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment