Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: run all snap-confine tests in c-unit-tests task #2433

Merged
merged 15 commits into from
Jan 12, 2017

Conversation

zyga
Copy link
Contributor

@zyga zyga commented Dec 8, 2016

This fixes older snap-confine tests. They got to bit-rot a little and required some changes:

  • snap-confine relies on having SNAP_NAME set.
  • to run /bin/true on i386 you need 32bit variants of some syscalls

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Copy link

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! LGTM

@zyga
Copy link
Contributor Author

zyga commented Jan 12, 2017

FYI: while debugging 14.04 test failure issues we realized that there are two separate things that were broken. Our PPA contained an old version of libseccomp that unfortunately sorted as newer due to version mangling in the PPA. In addition the nocheck tests in debian/rules were incorrect or missing which prevented the package from building. The first issue was fixed directly by removing the offending package. The second issue is being addressed here #2567 and needs to be merged into the 14.04 release branch once it lands in master.

@zyga zyga merged commit 9fd74c1 into canonical:master Jan 12, 2017
@zyga zyga deleted the snap-confine-older-tests branch January 12, 2017 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants