New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap/snapenv: don't obscure HOME if snap uses classic confinement #2442

Merged
merged 4 commits into from Dec 10, 2016

Conversation

Projects
None yet
3 participants
@zyga
Contributor

zyga commented Dec 9, 2016

This patch allows snaps using confinement: classic to see the real
value of the HOME environment variable. While all $SNAP_ environment
variables are present and have their usual values it allows snaps to
migrate data from the home directory into the proper location.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

snap/snapenv: don't obscure HOME if snap uses classic confinement
This patch allows snaps using `confinement: classic` to see the real
value of the HOME environment variable. While all `$SNAP_` environment
variables are present and have their usual values it allows snaps to
migrate data from the home directory into the proper location.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Show outdated Hide outdated snap/snapenv/snapenv.go Outdated
snap/snapenv: just don't set HOME with classic confinement
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Show outdated Hide outdated snap/snapenv/snapenv.go Outdated
snap/snapenv: tweak if/else
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

@zyga zyga requested a review from jdstrand Dec 9, 2016

@jdstrand

LGTM (with small nitpick)

Show outdated Hide outdated snap/snapenv/snapenv.go Outdated
snap/snapenv: tweak comment again
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

@zyga zyga merged commit acccba1 into snapcore:master Dec 10, 2016

5 of 6 checks passed

trusty-amd64 autopkgtest finished (failure)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:classic-HOME branch Dec 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment