Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
List packages via `snapd` REST API #258
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Thanks for this pull request. The branch looks very nice. Tests looks reasonable, no worries there :) One question about how this is going to be used inside webdm. I was assuming webdm would call snappyd directly via JS, is the plan to do something different? Don't get me wrong, the branch is fine and we need it in our work to move our cli client to the REST API, I just wonder how it relates to webdm. |
|
Cheers for the feedback @mvo5! The situation is thus: to move away from calling the
So a bunch of Go needs to be written by myself to handle interactions with these specific endpoints in the API. I could keep it all in As has been mentioned in IRC by @chipaca, the ideal situation would be to split out the client into it's own project but that's a bigger concern involving the Perhaps a snappy-client/rest lib or similar could be a suitable compromise until such time as efforts could be focused to fully separate the client and daemon code... If you think I'm barking up the wrong tree then don't feel shy to say so |
|
|
stevenwilkin commentedDec 16, 2015
This is a first step in migrating WebDM to the
snapdAPI and simply processes the response from the/1.0/packagesendpoint.Maybe a bit heavy handed when it comes to tests but there's a lot of error conditions...