/snapd

interfaces: miscellaneous policy updates for network-control, unity7, pulseaudio, default and home #2590

Merged
merged 9 commits into from Jan 10, 2017

Conversation

Reviewers

@zyga zyga

@mvo5 mvo5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jdstrand @manik-taneja @zyga @mvo5
@jdstrand
Contributor

jdstrand commented Jan 9, 2017

interfaces/network-control: allow rw on /dev/tun* and /dev/tap* (https://github.com/snapcore/snapd/issues/2557)
interfaces/unity7: allow snaps to read /usr/local/share/applications/* (LP: #1654666)
interfaces/pulseaudio: allow setgroups32 for armhf (LP: #1654585)
interfaces/default: allow use of infocmp by default (LP: #1646085)
interfaces/default: allow rw to /dev/shm/sem.snap.@{SNAP_NAME}.* (LP: #1653955)
interfaces/default: allow threads to modify comm values for its thread group
interfaces/unity7: allow use of Ubuntu MenuRegistrar (LP: #1646479)
interfaces/home: allow directory listing of /run/user/*/gvfs (LP: #1645413)

jdstrand added some commits Jan 9, 2017

@jdstrand
interfaces/network-control: allow rw on /dev/tun* and /dev/tap* 
/dev/tun* and /dev/tap* devices are created by opening /dev/net/tun and issuing
an ioctl(), so it makes sense to add these devices to the network-control
interface. Note that since these devices are dynamically created and removed,
we need dynamic hotplugging support in snapd. This PR does not attempt to
address hotplugging since that has not been implemented yet.
65b7ef7
@jdstrand
interfaces/unity7: allow snaps to read /usr/local/share/applications/* 
For snapd-xdg-open to work, snaps need to be able to read the desktop files in
/usr/local/share/applications and mimeapps.list
895444a
@jdstrand
interfaces/pulseaudio: allow setgroups32 for armhf (LP: #1654585)
1a81dc6
@jdstrand
interfaces/default: allow use of infocmp by default (LP: #1646085)
9f3b6f1
@jdstrand
interfaces/default: allow rw to /dev/shm/sem.snap.@{SNAP_NAME}.* (LP:… 
… #1653955)
667ccba
@jdstrand
fix typo in last commit
c9217c3
@jdstrand
interfaces/default: allow threads to modify comm values for its threa… 
…d group
a824373
@jdstrand
interfaces/unity7: allow use of Ubuntu MenuRegistrar
5903ce3
@jdstrand
interfaces/home: allow directory listing of /run/user/*/gvfs (LP: #16… 
…45413)

All checks have passed

6 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@mvo5
xenial-amd64 — autopkgtest finished (success)
Details
@mvo5
xenial-i386 — autopkgtest finished (success)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (success)
Details
@mvo5
yakkety-amd64 — autopkgtest finished (success)
Details
@mvo5
zesty-amd64 — autopkgtest finished (success)
Details
53849bb
@zyga

zyga approved these changes Jan 9, 2017
View changes

LGTM

@mvo5

mvo5 approved these changes Jan 10, 2017
View changes

Thank you!

@mvo5 mvo5 merged commit c00295e into snapcore:master Jan 10, 2017
6 checks passed

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
@jdstrand
Contributor

jdstrand commented Jan 10, 2017

Thanks for the review! :)

@jdstrand jdstrand deleted the jdstrand:policy-updates-xv branch Jan 10, 2017

@manik-taneja

manik-taneja commented Jan 11, 2017

I really appreciate the turn around on this one Jamie/Michael. Great work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment