overlord,overlord/snapstate: have UpdateMany retire/enable auto-aliases even without new revision #2605

Merged
merged 4 commits into from Jan 12, 2017

Projects

None yet

3 participants

@pedronis
Contributor
pedronis commented Jan 11, 2017 edited

This makes it so UpdateMany considers changes to auto-aliases from the snap-declaration even if there's no new updated revision.

Also tries to deal gracefully with auto-aliases transfers (even if likely rare) by retiring transfer sources' auto-aliases first.

TODO: need most of same logic to happen also just for Update (done in #2606)

@pedronis pedronis have UpdateMany take care of new or retired auto-aliases even if ther…
…e is no new snap revision, try to deal gracefully with transfers
cc0e0f2
@pedronis pedronis added this to the 2.21 milestone Jan 11, 2017
@pedronis
Contributor

based on #2602

pedronis added some commits Jan 11, 2017
@pedronis pedronis don't return tasks from UpdateMany with an empty updated fa7bc27
@pedronis pedronis Merge remote-tracking branch 'upstream/master' into orthog-alias-refresh
a137757
@pedronis pedronis Merge remote-tracking branch 'upstream/master' into orthog-alias-refresh
fa67181
- if hit.Unset() {
- return nil, nil
+ if !hit.Unset() {
+
@mvo5
mvo5 Jan 11, 2017 Collaborator

Is the extra newline here on purpose?

@mvo5
Collaborator
mvo5 commented Jan 12, 2017

Looks fine, my comment #2606 (comment) actually applies here but we can do this in a followup, it looks like we can probably extract a helper but its fine as it is.

@mvo5
mvo5 approved these changes Jan 12, 2017 View changes
@mvo5 mvo5 merged commit e7a61bd into snapcore:master Jan 12, 2017

5 of 6 checks passed

xenial-i386 autopkgtest finished (failure)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
@pedronis pedronis deleted the pedronis:orthog-alias-refresh branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment