/snapd

Backport to 15.04: Remap user-level environment to system-level for services. #273

Merged
merged 1 commit into from Dec 22, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@kyrofa @snappy-m-o @chipaca @mvo5
@kyrofa
Member

kyrofa commented Dec 22, 2015

Backport of #269 to 15.04.
@kyrofa
Remap user-level environment to system-level for services. 
Currently Snappy services define $SNAP_APP_USER_DATA_PATH to be
within /root/apps, however, there is no logic to create the
$SNAP_APP_USER_DATA_PATH like there is within binary wrappers,
which means any service that tries to use $SNAP_APP_USER_DATA_PATH
is trying to use a non-existing directory.

Having services write caches or logs into /root doesn't really make
sense anyway, so this commit remaps the user-level environment into
the system-level environment (i.e. $SNAP_APP_USER_DATA_PATH now =
$SNAP_APP_DATA_PATH) for services.

Fixes LP: #1527612

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
5c95856
@snappy-m-o
Contributor

snappy-m-o commented Dec 22, 2015

Can one of the admins verify this patch?
@chipaca
Member

chipaca commented Dec 22, 2015

I'd say "ok to test", @snappy-m-o, but you're still broken
@chipaca
Member

chipaca commented Dec 22, 2015

👍

mvo5 added a commit that referenced this pull request Dec 22, 2015

@mvo5
Merge pull request #273 from kyrofa/backport/remap_user_data_path_for… 
…_services

Backport to 15.04: Remap user-level environment to system-level for services.
77af42a

@mvo5 mvo5 merged commit 77af42a into snapcore:15.04 Dec 22, 2015
1 check failed

1 check failed

Integration tests No test results found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment