Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snapctl: add config in client to disable auth and use it in snapctl #2756
Conversation
All checks have passed
| @@ -63,18 +63,28 @@ type Config struct { | ||
| // BaseURL contains the base URL where snappy daemon is expected to be. | ||
| // It can be empty for a default behavior of talking over a unix socket. | ||
| BaseURL string | ||
| + | ||
| + // DisableAuth controls if the client should try to read the auth.json |
pedronis
Feb 1, 2017
Contributor
controls whether the client should send an Authorization header from reading the auth.json data.
|
I'm not commenting on the code changes, but I was somewhat surprised that the confined config hook tried to use /root/.snap/auth.json instead of /root/snap/$SNAP_NAME/$SNAP_REVISION/.snap/auth.json. Is the config hook not going through 'snap run' for its environment setup? Should it? |
|
@jdstrand the code path (we are supressing here) is for the "snap" command itself, it's not for snaps, it's using $HOME/.snap directly |
|
@jdstrand sorry being imprecise, it's not using $HOME even, it's using the home information from "os/user".Lookup |
Some checks were not successful
mvo5
added
the
Critical
label
Feb 1, 2017
mvo5
referenced this pull request
Feb 1, 2017
Merged
tests: add regression spread test for #1660941 #2757
All checks have passed
zyga
approved these changes
Feb 1, 2017
LGTM, extra comment sent on telegram but let's land this whenever you are ready.
mvo5 commentedFeb 1, 2017
LP: #1660941