/snapd

Support purging .snaps that use both data and user data paths. #283

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@kyrofa @snappy-m-o @chipaca @elopio @fgimenez @niemeyer
@kyrofa
Member

kyrofa commented Jan 4, 2016

Also support purging .snaps that are installed for multiple users.

Fixes LP: #1530924
@snappy-m-o
Contributor

snappy-m-o commented Jan 4, 2016

Can one of the admins verify this patch?

@kyrofa kyrofa referenced this pull request Jan 4, 2016

Closed

Change wrapper to use /root instead of $HOME if run as root. #264

@chipaca
Member

chipaca commented Jan 5, 2016

ok to test
@chipaca
Member

chipaca commented Jan 5, 2016

👍. Also, thank you for this!
@elopio
Member

elopio commented Jan 5, 2016

retest this please
@elopio
Member

elopio commented Jan 5, 2016

Ah, @kyrofa can you please merge with master?
@fgimenez Maybe we can tell m-o to do the merge before running the tests.
@fgimenez
Contributor

fgimenez commented Jan 7, 2016

Maybe we can tell m-o to do the merge before running the tests.

@elopio It's not a default feature but we could try to extend it.
@kyrofa
Support purging .snaps that use both data and user data paths. 
Also support purging .snaps that are installed for multiple users.

Fixes LP: #1530924

Signed-off-by: Kyle Fazzari <kyle@canonical.com>

Some checks were not successful

1 failing and 2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@snappy-m-o
Integration tests — Success 54 tests run, 0 skipped, 0 failed.
Details
coverage/coveralls — Coverage increased (+0.02%) to 67.681%
Details
783b692
@kyrofa
Member

kyrofa commented Jan 7, 2016

@elopio I rebased, but the integration tests are still failing.
@niemeyer
Contributor

niemeyer commented Jan 8, 2016

Thanks for the fix!

niemeyer added a commit that referenced this pull request Jan 8, 2016

@niemeyer
Merge pull request #283 from kyrofa/bugfix/1530924/purge_all_data_dirs 
Support purging .snaps that use both data and user data paths.
afbb82c

@niemeyer niemeyer merged commit afbb82c into snapcore:master Jan 8, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Integration tests Success 54 tests run, 0 skipped, 0 failed.
Details
coverage/coveralls Coverage increased (+0.02%) to 67.681%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment