unity7: support missing signals and methods for status icons #2840

Merged
merged 3 commits into from Feb 15, 2017

Conversation

Projects
None yet
4 participants
Contributor

3v1n0 commented Feb 13, 2017

Apps needs to be able to emit NewIconTheme path signal when their custom theme path
has changed, and they also have some callable methods that we currently don't support in snapd.

See https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/

LP: #1664297

3v1n0 added some commits Feb 13, 2017

unity7: NewIconThemePath should be an allowed signal
Apps uses this to update their custom icon theme
unity7: support missing methods in Status icons
Status Notification icons supports some methods too, and these need to be callable in order to support activation, secondary activation and scroll actions.
interfaces/builtin/unity7.go
@@ -435,7 +443,7 @@ dbus (receive)
# Lttng tracing is very noisy and should not be allowed by confined apps. Can
-# safely deny. LP: #1260491
+# safely deny. <a href='https://pad.lv/1260491'><a href='https://pad.lv/1260491'>LP: #1260491</a></a>
@jdstrand

jdstrand Feb 13, 2017

Contributor

Can you change this back to simply:

# safely deny. LP: #1260491
@3v1n0

3v1n0 Feb 13, 2017

Contributor

Ouch, sorry.... My userscript caused that... Fixed now.

zyga approved these changes Feb 14, 2017

LGTM

Test failure was unrelated. I restarted the run.

mvo5 approved these changes Feb 14, 2017

@mvo5 mvo5 merged commit 5c6d6fc into snapcore:master Feb 15, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment