many: differentiate between "distro" and "core" libexecdir #2844

Merged
merged 1 commit into from Feb 14, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Feb 14, 2017

Inside the core snap libexecdir is always /usr/lib/snapd but on the outside it
may be also /usr/libexec/snapd. In order for snap-confine and snap-exec to play
ball across the root filesystem transition we need to use the right path.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

many: differentiate between "distro" and "core" libexecdir
Inside the core snap libexecdir is always /usr/lib/snapd but on the outside it
may be also /usr/libexec/snapd. In order for snap-confine and snap-exec to play
ball across the root filesystem transition we need to use the right path.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

@zyga zyga changed the title from dirs: differentiate between "distro" and "core" libexecdir to many: differentiate between "distro" and "core" libexecdir Feb 14, 2017

@zyga zyga added this to the 2.23 milestone Feb 14, 2017

Contributor

Conan-Kudo commented Feb 14, 2017

I feel like this PR should be closed, since its commit is part of #2845...

Contributor

zyga commented Feb 14, 2017

@Conan-Kudo this is a github limitation. I specifically indicated in the other PR that it is stacked on top of this one. This branch can be reviewed and landed and reviews of the other branch should focus on the (stacked) new commit. Closing it would just focus reviewers to see a larger diff. I think this way the code is easier to track.

LGTM.

vosst approved these changes Feb 14, 2017

LGTM

@zyga zyga merged commit 9fc7024 into snapcore:master Feb 14, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:runtime-libexecdir branch Feb 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment