Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces/bluez,network-manager: implement ConnectedSlot policy #2948
Conversation
jdstrand
added some commits
Feb 27, 2017
Some checks were not successful
Some checks were not successful
|
@morphis - can you also review this PR since this is modifying interfaces you (or your team) implemented? |
|
@jdstrand LGTM |
jdstrand
added some commits
Feb 28, 2017
Some checks were not successful
All checks have passed
mvo5
added this to the
2.23 milestone
Mar 1, 2017
mvo5
merged commit b861d5a
into
snapcore:master
Mar 1, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
jdstrand
deleted the
jdstrand:bluez-nm-updates
branch
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jdstrand commentedFeb 27, 2017
The bluez and network-manager interfaces were the first two slot implementations and they rely solely on ConnectedPlug policy and do not implement ConnectedSlot policy. Shortly after these interfaces were committed it was decided that we would mediate both sides of the IPC like DBus. This PR brings network-manager and bluez up to date.
network-manager was tested by using 'dbus-send' from the wifi-ap snap. bluez was tested by stopping and starting ofono.
In addition to these changes, a couple of changes were made to network-manager:
This branch is on top of #2946