interfaces/bluez,network-manager: implement ConnectedSlot policy #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 27, 2017 20:42
|
@morphis - can you also review this PR since this is modifying interfaces you (or your team) implemented? |
|
@jdstrand LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bluez and network-manager interfaces were the first two slot implementations and they rely solely on ConnectedPlug policy and do not implement ConnectedSlot policy. Shortly after these interfaces were committed it was decided that we would mediate both sides of the IPC like DBus. This PR brings network-manager and bluez up to date.
network-manager was tested by using 'dbus-send' from the wifi-ap snap. bluez was tested by stopping and starting ofono.
In addition to these changes, a couple of changes were made to network-manager:
This branch is on top of #2946