Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
partition: deal with grub{,2}-editenv in tests #3001
Conversation
All checks have passed
mvo5
referenced this pull request
Mar 8, 2017
Merged
many: some opensuse patches that are ready to go into master #2989
Some checks were not successful
| @@ -31,23 +31,35 @@ import ( | ||
| "github.com/snapcore/snapd/osutil" | ||
| ) | ||
| +// grubEditenvCmd finds the right grub{,2}-editenv command | ||
| +func grubEditenvCmd() string { | ||
| + for _, exe := range []string{"grub-editenv", "grub2-editenv"} { |
|
Does this check for unversioned name first? I ask because some people are still shipping/using GRUB Legacy, and this could get confused because of it. That's why I suggest testing for versioned names first, because if they exist, they should be used. |
All checks have passed
mvo5
merged commit e423d85
into
snapcore:master
Mar 9, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedMar 8, 2017
Some distros ship grub-editenv as grub2-editenv. Add a tiny bit of code to deal with both names.