Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snap: skip /dev/ram from auto-import assertions to make it less noisy #3010
Conversation
All checks have failed
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
All checks have failed
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
|
do we expect people to want to try auto-import from /dev/ram in any situation but tests? if that's not case then SNAPPY_TESTING or SNAPD_TESTING (but needs rename everywhere) seems better |
mvo5
and others
added some commits
Apr 4, 2017
All checks have failed
Some checks were not successful
zyga
requested changes
Apr 4, 2017
This seems to be breaking tests. The extra DEBUG output is confusing tests that look at process output. Perhaps we could move it to stderr or use a different (or more feature rich) flag?
mvo5
added some commits
Apr 4, 2017
All checks have passed
pedronis
merged commit 2fb9cb3
into
snapcore:master
Apr 13, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedMar 9, 2017
Do not auto-import assertions from /dev/ram* unless in SNAPD_DEBUG
mode. This ensures that startup is (much) less noisy and we do not
spam syslog will useless errors.
Alternatively we could key this on "SNAPD_TESTING=1" and retire the current "SNAPPY_TESTING" that is used.