Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: drop udev tagging from framebuffer interface #3089
Conversation
|
I have merged master into this branch, resolved conflicts resulting from new snapd APIs and pushed this back to https://github.com/zyga/snapd/tree/fix-opengl-interface-udev-tag-dev-fb. I also contacted @chunsangjeong to make sure he is aware of this but I was unable to push into the pull request myself. Once the PR is updated it should be ready for review. |
| @@ -83,17 +82,6 @@ func (iface *FramebufferInterface) AppArmorConnectedPlug(spec *apparmor.Specific | ||
| // Getter for the security snippet specific to the plug | ||
| func (iface *FramebufferInterface) ConnectedPlugSnippet(plug *interfaces.Plug, slot *interfaces.Slot, securitySystem interfaces.SecuritySystem) ([]byte, error) { | ||
| - switch securitySystem { |
femdom
Mar 28, 2017
Contributor
Looks better now=)
Does it mean that udev tagging will never be enabled for the framebuffer interface?
zyga
Mar 28, 2017
Contributor
I think we will do a pass and enable it for everything. Now the problem is that any interface using udev tagging breaks every interface not using it that needs to access devices.
morphis
Mar 28, 2017
Contributor
We have a work item to convert all interfaces to use proper udev tagging for our next sprint which will then land in a future snapd version 2.24/2.25/2.26 depending on complexity and timing.
|
LGTM |
jdstrand
reviewed
Mar 29, 2017
Instead of just removing all the code, could we comment out the code and add a TODO comment that we are not doing this due to the bug and that we'll be reintroducing the udev tagging soon? This will help us remember to get back to this....
+1 on the approach and the effect to workaround the issue temporarily.
|
Added TODO comment and re-pulled https://github.com/zyga/snapd/tree/fix-opengl-interface-udev-tag-dev-fb. @zyga please check the updated branch. |
|
Thanks! I am going to test this today in the next 8 hours. |
|
@zyga I just rebased with the latest code and re-commited from there. Please check if it still conflicts with your branch.Thanks. |
|
Approving, but please adjust framebuffer_test.go accordingly (then your tests should start passing). |
Some checks were not successful
|
LGTM |
femdom
approved these changes
Mar 31, 2017
I tested the snapd on our system and was able to access the /dev/vchiq just ok.
zyga
and others
added some commits
Mar 31, 2017
All checks have failed
Some checks were not successful
mvo5
added this to the
2.24 milestone
Apr 3, 2017
zyga
merged commit 85c9855
into
snapcore:master
Apr 3, 2017
1 of 6 checks passed
arapulido
commented
Apr 3, 2017
|
Nice! Merged! Thanks all! |
chunsangjeong commentedMar 28, 2017
This will fix access denied of opengl interface when it's used with framebuffer
interface in the same snap. It's a first step of fix which allow us to unblock
the referenced case immediately and the proper udev tagging will be included in
a second step.
Fixes: https://bugs.launchpad.net/snapd/+bug/1675738
Signed-off-by: Chunsang Jeong chunsang.jeong@canonical.com