Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: rework header check for xfs/xqm.h #3094

Merged
merged 1 commit into from Mar 29, 2017

Conversation

morphis
Copy link
Contributor

@morphis morphis commented Mar 28, 2017

Building snap-confine on i386 fails on other operating systems with:

configure: WARNING: xfs/xqm.h: present but cannot be compiled
configure: WARNING: xfs/xqm.h: check for missing prerequisite headers?
configure: WARNING: xfs/xqm.h: see the Autoconf documentation
configure: WARNING: xfs/xqm.h: section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xqm.h: proceeding with the compiler's result
[...]
checking for xfs/xqm.h... no
configure: error: xfs/xqm.h unavailable

The official autoconf documentation recommends using a proper include
check in the AC_CHECK_HEADERS macro.

Building snap-confine on i386 fails on other operating systems with:

configure: WARNING: xfs/xqm.h: present but cannot be compiled
configure: WARNING: xfs/xqm.h:     check for missing prerequisite headers?
configure: WARNING: xfs/xqm.h: see the Autoconf documentation
configure: WARNING: xfs/xqm.h:     section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xqm.h: proceeding with the compiler's result
[...]
checking for xfs/xqm.h... no
configure: error: xfs/xqm.h unavailable

The official autoconf documentation recommends using a proper include
check in the AC_CHECK_HEADERS macro.
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zyga zyga merged commit 22caa2b into snapcore:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants