cmd: rework header check for xfs/xqm.h #3094

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
3 participants
Contributor

morphis commented Mar 28, 2017

Building snap-confine on i386 fails on other operating systems with:

configure: WARNING: xfs/xqm.h: present but cannot be compiled
configure: WARNING: xfs/xqm.h: check for missing prerequisite headers?
configure: WARNING: xfs/xqm.h: see the Autoconf documentation
configure: WARNING: xfs/xqm.h: section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xqm.h: proceeding with the compiler's result
[...]
checking for xfs/xqm.h... no
configure: error: xfs/xqm.h unavailable

The official autoconf documentation recommends using a proper include
check in the AC_CHECK_HEADERS macro.

cmd: rework header check for xfs/xqm.h
Building snap-confine on i386 fails on other operating systems with:

configure: WARNING: xfs/xqm.h: present but cannot be compiled
configure: WARNING: xfs/xqm.h:     check for missing prerequisite headers?
configure: WARNING: xfs/xqm.h: see the Autoconf documentation
configure: WARNING: xfs/xqm.h:     section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xqm.h: proceeding with the compiler's result
[...]
checking for xfs/xqm.h... no
configure: error: xfs/xqm.h unavailable

The official autoconf documentation recommends using a proper include
check in the AC_CHECK_HEADERS macro.

zyga approved these changes Mar 28, 2017

LGTM, thanks

mvo5 approved these changes Mar 28, 2017

@zyga zyga merged commit 22caa2b into snapcore:master Mar 29, 2017

4 of 6 checks passed

xenial-amd64 autopkgtest finished (failure)
Details
xenial-i386 autopkgtest finished (failure)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment