/snapd

cmd: explicit use of snapd sockets (for 2.23) #3101

Merged
merged 3 commits into from Mar 29, 2017

Conversation

Reviewers

@zyga zyga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mvo5 @zyga
@mvo5
Collaborator

mvo5 commented Mar 29, 2017

Backport of #3098 to 2.23

mvo5 added some commits Mar 28, 2017

@mvo5
Select what socket to use in cmd/snap{,ctl} 
So far we relied on apparmor to figure out what snap socket we
can use. However this fails on distributions without apparmor
support.
792d2e2
@mvo5
fix unit-tests

Some checks were not successful

2 failing and 4 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@mvo5
zesty-amd64 — autopkgtest finished (failure)
Details
@mvo5
xenial-amd64 — autopkgtest finished (success)
Details
@mvo5
xenial-i386 — autopkgtest finished (success)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (success)
Details
@mvo5
yakkety-amd64 — autopkgtest finished (success)
Details
185032c

@mvo5 mvo5 added this to the 2.23.6 milestone Mar 29, 2017

@zyga

zyga approved these changes Mar 29, 2017
View changes

+1

In retrospective I'd rename dirs.SnapdSocket to dirs.PrivilegedSnapdSocket and dirs.SnapSocket to dirs.UnprivilegedSnapdSocket because the one-letter difference in the original is too easy to miss.

@mvo5
revert unneeded variable name change

Some checks were not successful

1 errored and 5 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
@mvo5
xenial-amd64 — autopkgtest finished (success)
Details
@mvo5
xenial-i386 — autopkgtest finished (success)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (success)
Details
@mvo5
yakkety-amd64 — autopkgtest finished (success)
Details
@mvo5
zesty-amd64 — autopkgtest finished (success)
Details
6929f96

@mvo5 mvo5 merged commit 4c54a21 into snapcore:release/2.23 Mar 29, 2017
4 of 6 checks passed

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
xenial-amd64 autopkgtest running
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment