interfaces/mount: add function for parsing fstab-like file #3103

zyga · Mar 29, 2017

This is stacked on top of #3102. The new thing is the 2nd commit with a function for parsing a fstab-like file.

chipaca · Mar 30, 2017

suggest using IndexByte directly

Nice simplification, I didn't know about IndexByte. Done.

to me at least it'd make more sense if you trimmed the comment first, and trimmed the space second. Like

s := scanner.Text()
if i := strings.IndexByte(s, '#') {
    s = s[:i]
}
s = strings.TrimSpace(s)

Applied.

morphis · Mar 31, 2017

LGTM

zyga referenced this pull request Mar 30, 2017
Merged
interfaces/mount: add function for saving fstab-like file #3114

zyga deleted the zyga:load-fstab-file branch Mar 31, 2017

+        +	scanner := bufio.NewScanner(reader)
+        +	for scanner.Scan() {
+        +		s := strings.TrimSpace(scanner.Text())
+        +		if i := strings.Index(s, "#"); i != -1 {

+        +		s := strings.TrimSpace(scanner.Text())
+        +		if i := strings.Index(s, "#"); i != -1 {
+        +			s = strings.TrimSpace(s[0:i])
+        +		}

snapcore/snapd