/snapd

cmd: use libtool for the internal library #3108

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@morphis @zyga @mvo5
@morphis
Contributor

morphis commented Mar 29, 2017

This just cuts some hassle integration with how the helper library is
built. I could never get to pass the right -fPIC/-fpie combination
otherwise.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

Pushing this for further discussion as we ship this patch on other distributions (openSUSE, Fedora) to get snap-confine properly built.
@zyga
cmd: use libtool for the internal library 
This just cuts some hassle integration with how the helper library is
built. I could never get to pass the right -fPIC/-fpie combination
otherwise.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

All checks have failed

6 failing checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@mvo5
xenial-amd64 — autopkgtest finished (failure)
Details
@mvo5
xenial-i386 — autopkgtest finished (failure)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (failure)
Details
@mvo5
yakkety-amd64 — autopkgtest finished (failure)
Details
@mvo5
zesty-amd64 — autopkgtest finished (failure)
Details
00c1bba
@zyga
Contributor

zyga commented Mar 31, 2017

We want to try to integrate this with #3039 - we need 3039 so if we can marry them I'm +1000
@morphis
Contributor

morphis commented Apr 4, 2017

@zyga Can you take this change then and integrate it in your #3039 PR?

@mvo5 mvo5 added this to the 2.24 milestone Apr 4, 2017

@zyga
Contributor

zyga commented Apr 4, 2017

@morphis I just read your request; sure I'll do it.
@morphis
Contributor

morphis commented Apr 4, 2017

@zyga Thanks. Closing this PR then.

@morphis morphis closed this Apr 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment