cmd: import snapd-xdg-open and integrate with our infrastructure #3118

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

morphis commented Mar 31, 2017

Taken from revision 9382ccda6a5f870a254e378f3c9b54b8af27fb88 of
repository at https://github.com/snapcore/snapd-xdg-open

See https://forum.snapcraft.io/t/integrate-snapd-xdg-open-into-snapd-repository/100/ for more details

Some quick feedback, please tell me what you think.

cmd/configure.ac
@@ -109,6 +109,12 @@ AS_IF([test "x$enable_apparmor" = "xyes"], [
PKG_CHECK_MODULES([LIBUDEV], [libudev])
PKG_CHECK_MODULES([UDEV], [udev])
+PKG_CHECK_MODULES([GIO], [gio-2.0])
@zyga

zyga Mar 31, 2017

Contributor

We should make this part optional for deeply embedded environments.

@morphis

morphis Mar 31, 2017

Contributor

Sounds good.

@morphis

morphis Mar 31, 2017

Contributor

Added

@@ -0,0 +1,3 @@
+[D-BUS Service]
+Name=com.canonical.SafeLauncher
@zyga

zyga Mar 31, 2017

Contributor

I really really wish we could change this name.

@morphis

morphis Mar 31, 2017

Contributor

I saw there are some discussions around having something io.snapcraft.* based. I am fine with that and we can introduce this as a variant in another PR and migrate to it over time.

cmd: import snapd-xdg-open and integrate with our infrastructure
Taken from revision 9382ccda6a5f870a254e378f3c9b54b8af27fb88 of
repository at https://github.com/snapcore/snapd-xdg-open
Contributor

niemeyer commented Mar 31, 2017

@morphis Now that we have your help, I think it's time to fix this in the proper way. I'll follow through in the forum.

@niemeyer niemeyer closed this Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment