cmd: import snapd-xdg-open and integrate with our infrastructure #3118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morphis
force-pushed
the
f/import-xdg-open
branch
from
c27192b to
2b62c58
Compare
zyga
reviewed
Mar 31, 2017
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
Some quick feedback, please tell me what you think.
| @@ -0,0 +1,3 @@ | |||
| [D-BUS Service] | |||
| Name=com.canonical.SafeLauncher | |||
Contributor
There was a problem hiding this comment.
I really really wish we could change this name.
Contributor
Author
There was a problem hiding this comment.
I saw there are some discussions around having something io.snapcraft.* based. I am fine with that and we can introduce this as a variant in another PR and migrate to it over time.
cmd/configure.ac
Outdated
| PKG_CHECK_MODULES([LIBUDEV], [libudev]) | ||
| PKG_CHECK_MODULES([UDEV], [udev]) | ||
|
|
||
| PKG_CHECK_MODULES([GIO], [gio-2.0]) |
Contributor
There was a problem hiding this comment.
We should make this part optional for deeply embedded environments.
Taken from revision 9382ccda6a5f870a254e378f3c9b54b8af27fb88 of repository at https://github.com/snapcore/snapd-xdg-open
morphis
force-pushed
the
f/import-xdg-open
branch
from
2b62c58 to
921cb39
Compare
Contributor
|
@morphis Now that we have your help, I think it's time to fix this in the proper way. I'll follow through in the forum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from revision 9382ccda6a5f870a254e378f3c9b54b8af27fb88 of
repository at https://github.com/snapcore/snapd-xdg-open
See https://forum.snapcraft.io/t/integrate-snapd-xdg-open-into-snapd-repository/100/ for more details