interfaces/mount: add InfoEntry type #3129

Merged
merged 5 commits into from Apr 11, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Apr 3, 2017

This patch adds the InfoEntry structure. The structure represents what
is found in /proc/$PID/mountinfo, aka the table of mounted things.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

zyga added some commits Mar 24, 2017

interfaces/mount: add InfoEntry type
This patch adds the InfoEntry structure. The structure represents what
is found in /proc/$PID/mountinfo, aka the table of mounted things.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Looks good. One open question, would it make sense in making OptionalFlds an array (of tuples?), or will we never be interested in the details of it?

tests: improve debug output
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Contributor

zyga commented Apr 4, 2017

We're not interested in the details (yet). Once the need arises we can change it (or just add a function to parse the options field into its components.

zyga added some commits Apr 5, 2017

mvo5 approved these changes Apr 11, 2017

@mvo5 mvo5 merged commit 8e5e4a5 into snapcore:master Apr 11, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:mountinfo-1 branch Apr 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment