interfaces/mount: add high-level Profile functions #3135

zyga · Apr 4, 2017

This code tweaks earlier functions that operated on []Entry to operate
on *Profile (profile being simply a struct with []Entry field for now).

There are two more functions, one that loads and one that saves a profile
from a given file. Everything is fully tested.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

niemeyer · Apr 5, 2017

Nice!

Thanks!

I'm assuming nothing changed below other than moving it.

Yes, all the same

Do we need this? Isn't the use case to write to a file always?

I used it to write tests. We don't need it but I'd keep it just because it tests nicely.

chipaca · Apr 6, 2017

lurvely.

hm. Maybe we want to have osutil.AtomicWriteDefault?

As in with 0600 permissions or what?

zyga referenced this pull request Apr 4, 2017
Merged
interfaces/mount: add function for saving fstab-like file #3114

zyga deleted the zyga:profile-apis branch Apr 6, 2017

+        +// ReadProfile reads and parses a mount profile.
+        +//
+        +// The supported format is described by fstab(5).
+        +func ReadProfile(reader io.Reader) (*Profile, error) {

+        +//
+        +// The supported format is described by fstab(5).
+        +// Note that there is no support for comments.
+        +func (p *Profile) WriteTo(writer io.Writer) (int64, error) {

+        +	if _, err := p.WriteTo(&buf); err != nil {
+        +		return err
+        +	}
+        +	return osutil.AtomicWriteFile(fname, buf.Bytes(), 0600, osutil.AtomicWriteFlags(0))

snapcore/snapd