cmd: explicitly set _GNU_SOURCE and _FILE_OFFSET_BITS for xfs support #3146

Merged

zyga merged 1 commit into snapcore:master from morphis:f/use-proper-include-check-xqm-h

Apr 6, 2017

Contributor

morphis commented Apr 6, 2017

This will unblock builds on i386 on other distributions not being Debian
or Ubuntu.

Also see https://patchwork.kernel.org/patch/9486535/ and
https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html

Contributor

morphis commented Apr 6, 2017

Works quite well for Fedora: https://koji.fedoraproject.org/koji/taskinfo?taskID=18809098

mvo5 added this to the 2.24 milestone Apr 6, 2017

mvo5 approved these changes Apr 6, 2017

View changes

Contributor

zyga commented Apr 6, 2017

snap-confine/seccomp-support.c:43:26: error: ISO C99 requires whitespace after the macro name [-Werror]
 #define _FILE_OFFSET_BITS=64


      cmd: explicitly set _GNU_SOURCE and _FILE_OFFSET_BITS for xfs support

This will unblock builds on i386 on other distributions not being Debian
or Ubuntu.

Also see https://patchwork.kernel.org/patch/9486535/ and
https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html

cfc1841

zyga approved these changes Apr 6, 2017

View changes

+1

zyga merged commit `ba92368` into snapcore:master Apr 6, 2017
6 checks passed

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

xenial-amd64 autopkgtest finished (success)

Details

xenial-i386 autopkgtest finished (success)

Details

xenial-ppc64el autopkgtest finished (success)

Details

yakkety-amd64 autopkgtest finished (success)

Details

zesty-amd64 autopkgtest finished (success)

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.