Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errtracker: never send errtracker reports when running under SNAPPY_TESTING #3148

Merged
merged 3 commits into from Apr 7, 2017

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Apr 6, 2017

No description provided.

if osutil.GetenvBool("SNAPPY_TESTING") {
logger.Noticef("errtracker.Report is *not* send because SNAPPY_TESTING is set")
logger.Noticef("report: %v", report)
return "oops-not-send", nil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe oops-not-sent ?


// see if we run in testing mode
if osutil.GetenvBool("SNAPPY_TESTING") {
logger.Noticef("errtracker.Report is *not* send because SNAPPY_TESTING is set")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/send/sent/

Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

Copy link
Contributor

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvo5 mvo5 merged commit ae8f59a into snapcore:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants