errtracker: never send errtracker reports when running under SNAPPY_TESTING #3148

Merged

mvo5 merged 3 commits into snapcore:master from mvo5:errtracker-honor-tests

Apr 7, 2017

Collaborator

mvo5 commented Apr 6, 2017

No description provided.


      never send errtracker reports when running under SNAPPY_TESTING

4ecb09b

zyga reviewed Apr 6, 2017

View changes

errtracker/errtracker.go

    
        +	if osutil.GetenvBool("SNAPPY_TESTING") {

        +		logger.Noticef("errtracker.Report is *not* send because SNAPPY_TESTING is set")

        +		logger.Noticef("report: %v", report)

        +		return "oops-not-send", nil

zyga Apr 6, 2017

Contributor

maybe oops-not-sent ?


      fix typo

5008e7f

zyga reviewed Apr 6, 2017

View changes

errtracker/errtracker.go

    
        +

        +	// see if we run in testing mode

        +	if osutil.GetenvBool("SNAPPY_TESTING") {

        +		logger.Noticef("errtracker.Report is *not* send because SNAPPY_TESTING is set")

zyga Apr 6, 2017

Contributor

s/send/sent/


      one more typo (thanks to zyga)

435e6d8

zyga approved these changes Apr 6, 2017

View changes

LGTM :-)

fgimenez approved these changes Apr 7, 2017

View changes

LGTM

mvo5 merged commit `ae8f59a` into snapcore:master Apr 7, 2017
6 checks passed

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed

Details

xenial-amd64 autopkgtest finished (success)

Details

xenial-i386 autopkgtest finished (success)

Details

xenial-ppc64el autopkgtest finished (success)

Details

yakkety-amd64 autopkgtest finished (success)

Details

zesty-amd64 autopkgtest finished (success)

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.