Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
overlord/ifacestate: automatically rename connections on core snap #3160
+66
−0
Conversation
zyga
referenced this pull request
Apr 10, 2017
Merged
many: rename two core plugs that clash with slot names #3154
All checks have failed
zyga
added this to the
2.24 milestone
Apr 10, 2017
|
This branch depends on #3154 |
| + oldPlugRef := interfaces.PlugRef{Snap: "core", Name: plugName} | ||
| + oldConnRef := interfaces.ConnRef{PlugRef: oldPlugRef, SlotRef: slotRef} | ||
| + oldID := oldConnRef.ID() | ||
| + // new connection |
chipaca
Apr 10, 2017
Member
(FTR I think it's alright, if a little surprising, to have it this way instead of inside the if; don't change it if you'd only start the tests over for this change)
zyga
added some commits
Apr 10, 2017
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
All checks have passed
All checks have passed
mvo5
modified the milestones:
2.25,
2.24
Apr 11, 2017
zyga
added some commits
Apr 11, 2017
All checks have passed
zyga
merged commit b3e03b5
into
snapcore:master
Apr 13, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:rename-core-conns
branch
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedApr 10, 2017
This patch completes the rename cycle by renaming stored connections
to and from the core snap with clashing plug and slot name.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com