overlord/ifacestate: automatically rename connections on core snap #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch completes the rename cycle by renaming stored connections to and from the core snap with clashing plug and slot name. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
|
This branch depends on #3154 |
chipaca
approved these changes
Apr 10, 2017
overlord/ifacestate/helpers.go
Outdated
| oldPlugRef := interfaces.PlugRef{Snap: "core", Name: plugName} | ||
| oldConnRef := interfaces.ConnRef{PlugRef: oldPlugRef, SlotRef: slotRef} | ||
| oldID := oldConnRef.ID() | ||
| // new connection |
There was a problem hiding this comment.
any reason not to have everything from here down inside the if?
There was a problem hiding this comment.
(FTR I think it's alright, if a little surprising, to have it this way instead of inside the if; don't change it if you'd only start the tests over for this change)
There was a problem hiding this comment.
Aha, good point. I'll make that happen.
stolowski
approved these changes
Apr 10, 2017
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
The network-bind plug is no longer present on the core snap so we don't need to rename it anymore. Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch completes the rename cycle by renaming stored connections
to and from the core snap with clashing plug and slot name.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com