Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snap-confine,browser-support: /dev/tty for snap-confine, misc browser-support for gnome-shell #3161
Conversation
jdstrand
added some commits
Apr 10, 2017
All checks have failed
All checks have failed
|
@zyga - made a refinement to one of the rules, can you recheck? |
|
@zyga - I guess you are talking about the shmfd access-- I don't know, it is in the chrome binary. I have a feeling that it is because of network printing that magically started working on zesty, but that is wild speculation. Limiting this new rule to owner makes it consistent with the other /dev/shm accesses and having it in the reserved 'allow-sandbox: true' section limits who can use it though. |
All checks have failed
| @@ -109,7 +109,7 @@ func (s *BrowserSupportInterfaceSuite) TestConnectedPlugSnippetWithoutAttrib(c * | ||
| c.Assert(err, IsNil) | ||
| c.Assert(apparmorSpec.SecurityTags(), DeepEquals, []string{"snap.other.app2"}) | ||
| snippet := apparmorSpec.SnippetForTag("snap.other.app2") | ||
| - c.Assert(string(snippet), testutil.Contains, `# Description: Can access various APIs needed by modern browers`) | ||
| + c.Assert(string(snippet), testutil.Contains, `# Description: Can access various APIs needed by modern browsers`) |
|
@mvo5 - ah thanks for the testsuite fix. |
|
@jdstrand Your very welcome, thanks for the real fix in there :) |
jdstrand
added some commits
Apr 10, 2017
Some checks were not successful
|
With the autopkgtests, there is one consistent unrelated failure: tests/main/interfaces-network-bind Travis passes now so with two +1s, merging. |
jdstrand commentedApr 10, 2017
•
Edited 1 time
-
jdstrand
Apr 10, 2017