Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: ensure network-bind and core-support are connected #3164
Conversation
All checks have failed
niemeyer
approved these changes
Apr 10, 2017
LGTM, although the different expressions did make me wonder.
| + | ||
| + echo "Ensure interfaces are connected" | ||
| + snap interfaces | MATCH ":core-support.*core:core-support-plug" | ||
| + snap interfaces | MATCH ":network-bind.*core" |
mvo5
Apr 10, 2017
Collaborator
I think the should be exactly alike, the test is currently failing the network-bind is not connected and we still don't know why. This is under investigation. I will fix the test!
|
@mvo5 thanks for this! I think that the network-bind test should be covered in 3145 https://github.com/snapcore/snapd/pull/3145/files#diff-23e6c1e2bbf5a1a24798303971f19b99R74, is that correct? with the changes in that branch the check works just fine. The core-support verification in this PR is not done elsewhere afaik. |
|
@fgimenez 3145 fixes the error after it has happened, i.e. it fixes the now disconnected core snap. What I'm curious about is why we have a disconnected network-bind plug in the first place. Also why does core-support connects and network-bind does not? |
mvo5
referenced this pull request
Apr 10, 2017
Merged
interfaces/builtin: fold network-bind into core-support #3166
mvo5
added this to the
2.24 milestone
Apr 10, 2017
|
Superseed in favour of #3167 |
mvo5 commentedApr 10, 2017
No description provided.