Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces/builtin: fold network-bind into core-support #3166
Conversation
All checks have passed
| @@ -79,7 +79,9 @@ owner /boot/uboot/config.txt.tmp rwk, | ||
| func NewCoreSupportInterface() interfaces.Interface { | ||
| return &commonInterface{ | ||
| name: "core-support", | ||
| - connectedPlugAppArmor: coreSupportConnectedPlugAppArmor, | ||
| + // NOTE: cure-support implicitly contains the rules from network-bind. | ||
| + connectedPlugAppArmor: coreSupportConnectedPlugAppArmor + networkBindConnectedPlugAppArmor, |
added a commit
to snapcore/core
that referenced
this pull request
Apr 10, 2017
mvo5
referenced this pull request
in snapcore/core
Apr 10, 2017
Merged
the core snap only needs core-support (not network-bind) #33
|
The corresponding core snap change: snapcore/core#33 - then we need to adjust the test in #3164 and we are good to go with 2.24 |
mvo5
added this to the
2.24 milestone
Apr 10, 2017
mvo5
referenced this pull request
Apr 11, 2017
Merged
interfaces: fold network bind into core support with tests #3167
mvo5
merged commit e2a856c
into
snapcore:master
Apr 11, 2017
6 checks passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:fold-network-bind-into-core-support
branch
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedApr 10, 2017
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com