interfaces,overlord: log interface auto-connection failures #3174

Merged
merged 3 commits into from Apr 12, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Apr 11, 2017

We recently learned that the auto-connection logic is not as nice as we would like it to be.
As the first step towards fixing it let's add some diagnostic messages that we can use
to reason about what is going on in a given system.

zyga added some commits Apr 11, 2017

interfaces: fix {Plug,Slot}Ref.String to work on non-pointers
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
overlord/ifacestate: add debug messages on failing auto-connections
Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

mvo5 approved these changes Apr 11, 2017

Nice!

LGTM, just one question.

@@ -67,7 +67,7 @@ type SlotRef struct {
}
// String returns the "snap:slot" representation of a slot reference.
-func (ref *SlotRef) String() string {
@stolowski

stolowski Apr 11, 2017

Contributor

Is there a particular reason for this change?

@zyga

zyga Apr 11, 2017

Contributor

Yes, with the pointer receiver the method would not be used on plain (non pointer) objects.

@mvo5 mvo5 merged commit 36e7265 into snapcore:master Apr 12, 2017

6 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:log-autoconnect-failures branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment