Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: copy snap-confine apparmor profile into testbed #3194

Merged
merged 2 commits into from Apr 13, 2017

Conversation

zyga
Copy link
Collaborator

@zyga zyga commented Apr 13, 2017

Ever since we started executing snap-confine from the core snap we rely
on a copy of the apparmor profile from the Debian package to generate
the apparmor profile for snap-confine in the core snap.

My recent changes to the snap-confine required an update to the profile
and I noticed that all the test have failed because apparmor profile
in the core snap was not kept up-to-date.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

Ever since we started executing snap-confine from the core snap we rely
on a copy of the apparmor profile from the Debian package to generate
the apparmor profile for snap-confine in the core snap.

My recent changes to the snap-confine required an update to the profile
and I noticed that all the test have failed because apparmor profile
in the core snap was not kept up-to-date.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Copy link

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but it would be nice if this was closer to the snap-confine copy.

@zyga
Copy link
Collaborator Author

zyga commented Apr 13, 2017

@jdstrand one of @chipaca's branches are converting that to cp -a with simpler set of files to manage. I will update it then.

Copy link
Contributor

@ogra1 ogra1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
@zyga zyga merged commit 6b2d8cf into snapcore:master Apr 13, 2017
@zyga zyga deleted the fix-aa-profile branch April 13, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants