Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snap-repair: add `snap-repair run` #3226
Conversation
mvo5
added some commits
Apr 24, 2017
All checks have failed
Some checks were not successful
mvo5
changed the title from
snap-repair: add `snap-repair run` #3221
to
snap-repair: add `snap-repair run`
Apr 24, 2017
mvo5
added some commits
Apr 24, 2017
Some checks were not successful
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
| + | ||
| +// FIXME: bypass the assertion DB entirely and collect all repair | ||
| +// bits in /var/lib/snapd/repair/ | ||
| +// FIXME: create a copy of the critical assertion code to protect |
zyga
May 9, 2017
Contributor
I think that we should treat repair code change as a bootloader update. We should not do it unless we actually want to. It should not be automatically done whenever we change snapd itself. It should be extensively tested automatically as well as manually and only updated if we found an issue that needs addressing. The risk of just rebuilding this from the varying code all the time is that, as our last line of defence, it will fail us in the only moment where it needs to work.
mvo5
added some commits
May 10, 2017
All checks have failed
All checks have failed
All checks have failed
Some checks were not successful
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
Some checks were not successful
Some checks were not successful
|
Closing for now as this will need some rework for the latest changes in the forum discussion. |
mvo5
closed this
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedApr 24, 2017
•
Edited 1 time
-
mvo5
Apr 24, 2017
This outlines the snap-repair run command as discussed in https://forum.snapcraft.io/t/repair-capability-emergency-fixes/311
Based on #3211
With comments from #3221