Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: re-enable and moderninze /media sharing test #3254
Conversation
zyga
requested a review
from
jdstrand
Apr 28, 2017
| test ! -e /media/dst/canary | ||
| - snapd-hacker-toolbelt.busybox sh -c 'mount --bind /media/src /media/dst' | ||
| + test-snapd-tools.cmd mount --bind /media/src /media/dst |
jdstrand
May 1, 2017
Contributor
test-snapd-tools.cmd doesn't seem to be a thing:
$ snap info test-snapd-tools
name: test-snapd-tools
summary: "Tools for testing the snapd application"
publisher: canonical
contact: snappy-canonical-storeaccount@canonical.com
description: |
A tool to test snapd
commands:
- test-snapd-tools.block
- test-snapd-tools.cat
- test-snapd-tools.echo
- test-snapd-tools.fail
- test-snapd-tools.head
- test-snapd-tools.success
tracking: edge
installed: 1.0+fake1 (5) 8kB -
refreshed: 2016-07-07 04:16:28 -0500 CDT
channels:
latest/stable: 1.0 (3) 8kB -
latest/edge: 1.0+fake1 (5) 8kB -
$ test-snapd-tools.cmd uptime
test-snapd-tools.cmd: command not found
$ ls /snap/bin/test-snapd-tools.cmd
ls: cannot access '/snap/bin/test-snapd-tools.cmd': No such file or directory
jdstrand
May 2, 2017
Contributor
I see that tests/lib/snaps/test-snapd-tools exists, it has 'cmd' and you are using install_local. The disparity between this and test-snapd-tools in the store is confusing. Can the one in the store be removed?
zyga
May 3, 2017
Contributor
I think the one in the store has to be there as some tests install one from the store and some install the local one. The difference is that since you now have full assertions auto-connections take place. I think what is missing is a cron job that publishes the snaps from the tree into the store.
@fgimenez ^^ what is your opinion?
fgimenez
May 3, 2017
Contributor
@zyga indeed, we need test-snapd-tools in the store at least for the auto-refresh tests, probably for others too.
Because we don't use all of its features from the store version it is out of sync from the source on snapd's tree, I'll push an up to date version to the store asap.
IMO given the low change rate of this snap we don't need to put in place a function to watch the source and have it updated in the store, but can be done easily, let me know what do you think.
zyga commentedApr 28, 2017
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com