Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add ttyAMA0 to allowed devices, needed for pi3 BT #3256
Conversation
Some checks were not successful
jdstrand
requested changes
Apr 28, 2017
We have quite a few tests for the different patterns, can you update them for AMA?
| @@ -50,7 +50,7 @@ func (iface *SerialPortInterface) String() string { | ||
| // - ttyXRUSBx (Exar Corp. USB UART devices) | ||
| // - ttySX (UART serial ports) | ||
| // - ttyOX (UART serial ports on ARM) | ||
| -var serialDeviceNodePattern = regexp.MustCompile("^/dev/tty(USB|ACM|XRUSB|S|O)[0-9]+$") | ||
| +var serialDeviceNodePattern = regexp.MustCompile("^/dev/tty(USB|ACM|AMA|XRUSB|S|O)[0-9]+$") |
ogra1
added some commits
Apr 28, 2017
All checks have failed
Some checks were not successful
zyga
approved these changes
Apr 28, 2017
Some things would be easier if you had just appended to the list of slots rather than inserting in the middle but it's all OK. Merging.
zyga
merged commit 2f81a24
into
master
Apr 28, 2017
6 of 8 checks passed
artful-amd64
autopkgtest finished (failure)
Details
xenial-amd64
autopkgtest finished (failure)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
ttyAMA-for-serial-interface
branch
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ogra1 commentedApr 28, 2017
bluetooth support on the pi3 needs to use the serial-port interface to initialize the BT subsystem with hciattach.
it uses the ttyAMA0 interface for this, allow use of /dev/ttyAMA0 by the serial-port interface