cmd/snap, client: add "whoami" command #3277

Merged

chipaca merged 2 commits into snapcore:master from chipaca:whoami

May 8, 2017

Member

chipaca commented May 5, 2017

No description provided.

stolowski approved these changes May 5, 2017

View changes

Nice. +1


      cmd/snap, client: add "whoami" command

6329e0e

zyga reviewed May 8, 2017

View changes

cmd/snap/cmd_whoami.go

    
        +	if err != nil {

        +		return err

        +	}

        +	if email == "" {

zyga May 8, 2017

Contributor

What is this for?

zyga approved these changes May 8, 2017

View changes

LGTM, please add a comment explaining the empty email replacement logic though.

Contributor

zyga commented May 8, 2017 •

Edited 1 time

zyga
May 8, 2017

After reading the corresponding forum thread I suggest we do try to make the output similar to what snapcraft whoami prints.

Member

chipaca commented May 8, 2017

@zyga done.


      address issues from review

169dd99

chipaca merged commit `6b50028` into snapcore:master May 8, 2017
7 checks passed

7 checks passed

artful-amd64 autopkgtest finished (success)

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

xenial-amd64 autopkgtest finished (success)

Details

xenial-i386 autopkgtest finished (success)

Details

xenial-ppc64el autopkgtest finished (success)

Details

yakkety-amd64 autopkgtest finished (success)

Details

zesty-amd64 autopkgtest finished (success)

Details

chipaca deleted the chipaca:whoami branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can't perform that action at this time.