Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
daemon: do not allow to install ubuntu-core anymore #3289
+62
−9
Conversation
mvo5
added some commits
May 10, 2017
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
Some checks were not successful
| @@ -910,6 +910,20 @@ func snapUpdateMany(inst *snapInstruction, st *state.State) (msg string, updated | ||
| return msg, updated, tasksets, nil | ||
| } | ||
| +func verifySnapInstructions(inst *snapInstruction) error { | ||
| + if inst.Action == "install" { |
zyga
May 10, 2017
•
Edited 1 time
-
zyga
May 11, 2017
Contributor
Edited 1 time
-
May 11, 2017
Nitpick, switch/case on the inst.Action, this will also make the code less indented.
| + echo "Installing ubuntu-core should fail" | ||
| + exit 1 | ||
| + fi | ||
| + cat stderr.out | MATCH "cannot install \"ubuntu-core\", please use \"core\" instead" |
mvo5
and others
added some commits
May 10, 2017
All checks have failed
All checks have passed
mvo5
modified the milestone:
2.26
May 11, 2017
All checks have passed
chipaca
merged commit 9fef75c
into
snapcore:master
May 16, 2017
7 checks passed
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedMay 10, 2017
•
Edited 1 time
-
mvo5
May 10, 2017
There is no need to install ubuntu-core any-more with current snapd.
People with existing installs will auto-transition to core on the
next refresh.
Some more background: https://forum.snapcraft.io/t/error-using-obsolete-ubuntu-core-snap-on-classic/525/3
I.e. we will also freeze ubuntu-core as part of this effort so that we don't have to maintain compatibility code in snapd itself that checks for both ubuntu-core and core all the time.
LP: #1689332