daemon: do not allow to install ubuntu-core anymore #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to install ubuntu-core anymore with current snapd. People with existing installs will auto-transition to core on the next refresh. LP: #1689332
zyga
approved these changes
May 10, 2017
tests/main/install-errors/task.yaml
Outdated
| echo "Installing ubuntu-core should fail" | ||
| exit 1 | ||
| fi | ||
| cat stderr.out | MATCH "cannot install \"ubuntu-core\", please use \"core\" instead" |
There was a problem hiding this comment.
nitpick, use single quotes here
daemon/api.go
Outdated
| @@ -910,6 +910,20 @@ func snapUpdateMany(inst *snapInstruction, st *state.State) (msg string, updated | |||
| return msg, updated, tasksets, nil | |||
| } | |||
|
|
|||
| func verifySnapInstructions(inst *snapInstruction) error { | |||
| if inst.Action == "install" { | |||
There was a problem hiding this comment.
Nitpick, switch/case on the inst.Action, this will also make the code less indented.
There was a problem hiding this comment.
Indeed, that is nicer, thank you!
chipaca
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to install ubuntu-core any-more with current snapd.
People with existing installs will auto-transition to core on the
next refresh.
Some more background: https://forum.snapcraft.io/t/error-using-obsolete-ubuntu-core-snap-on-classic/525/3
I.e. we will also freeze ubuntu-core as part of this effort so that we don't have to maintain compatibility code in snapd itself that checks for both ubuntu-core and core all the time.
LP: #1689332