store: fix panic error in auth #3303

Merged
merged 6 commits into from May 11, 2017

Conversation

Projects
None yet
4 participants
Contributor

stolowski commented May 11, 2017

Fix panic on DNS error in auth, caused by shadowing of err. Added a couple extra tests. Store requests do not have this bug, only auth.

stolowski added some commits May 11, 2017

@mvo5 mvo5 added this to the 2.26.1 milestone May 11, 2017

zyga approved these changes May 11, 2017

+1

thank you

Contributor

stolowski commented May 11, 2017

Hmm, looks like the test I added fails with 503 for some reason when run on Travis, which is different error that I get locally and expect in the test:

store_test.go:2963:
    c.Assert(err, ErrorMatches, `Post http://nonexistingserver909123.com/updates/: dial tcp: lookup nonexistingserver909123.com on .*: no such host`)
... error string = "cannot query the store for updates: got unexpected HTTP status code 503 via POST to \"http://nonexistingserver909123.com/updates/\""
... regex string = "Post http://nonexistingserver909123.com/updates/: dial tcp: lookup nonexistingserver909123.com on .*: no such host"

stolowski and others added some commits May 11, 2017

@mvo5 mvo5 merged commit c5aadff into snapcore:master May 11, 2017

1 of 7 checks passed

artful-amd64 autopkgtest running
Details
xenial-amd64 autopkgtest running
Details
xenial-i386 autopkgtest running
Details
xenial-ppc64el autopkgtest running
Details
yakkety-amd64 autopkgtest running
Details
zesty-amd64 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment