spread.yaml: rename host's http proxy env vars #3315

Merged
merged 2 commits into from May 15, 2017

Conversation

Projects
None yet
3 participants
Contributor

fgimenez commented May 12, 2017

This way we make sure that we only use the host's proxy settings when we intend to.

@fgimenez fgimenez changed the title from rename host's http proxy env vars to spread.yaml: rename host's http proxy env vars May 12, 2017

zyga approved these changes May 15, 2017

Looks good, LGTM assuming this does not affect our ability to run in autopkgtests

Contributor

fgimenez commented May 15, 2017

@zyga thank you! :)

I don't think this will affect autopkgtests (just take a look at the results of the build in this PR), we use http_proxy (lower case) in autopkgtest preparation here https://github.com/snapcore/snapd/blob/master/packaging/ubuntu-16.04/tests/integrationtests#L7 setting it up for both snapd and the general environment before launching spread, and that env var is set in the autopkgtest executor (you can check it out by searching for http_proxy here https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-snappy-dev-image/artful/amd64/s/snapd/20170512_165014_e079f@/log.gz), so the spread env vars are not involved in this case.

@pedronis pedronis merged commit ecf759e into snapcore:master May 15, 2017

6 of 7 checks passed

xenial-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment