/snapd

make /etc/localtime writable in timezone_control #3316

Merged
merged 2 commits into from May 15, 2017

Conversation

Reviewers

@zyga zyga

@jdstrand jdstrand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ogra1 @morphis @niemeyer @zyga @jdstrand
@ogra1
Contributor

ogra1 commented May 12, 2017

the timezone_control interface only allows changing /etc/timezone and /etc/writable/timezone. systemd-timedated also updated the link of /etc/localtime and /etc/writable/localtime ... allow access to this file too (https://bugs.launchpad.net/snappy/+bug/1650688)
@ogra1
make /etc/localtime writable in timezone_control 
the timezone_control interface only allows changing /etc/timezone and /etc/writable/timezone. systemd-timedated also updated the link of /etc/localtime and /etc/writable/localtime ... allow access to this file too (https://bugs.launchpad.net/snappy/+bug/1650688)

Some checks were not successful

4 failing and 4 successful checks
continuous-integration/travis-ci/push — The Travis CI build failed
Details
@mvo5
xenial-amd64 — autopkgtest finished (failure)
Details
@mvo5
xenial-i386 — autopkgtest finished (failure)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (failure)
Details
@mvo5
artful-amd64 — autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
@mvo5
yakkety-amd64 — autopkgtest finished (success)
Details
@mvo5
zesty-amd64 — autopkgtest finished (success)
Details
dc6eff2
@jdstrand

jdstrand approved these changes May 12, 2017
View changes

This looks fine (see man 5 localtime).

@morphis
Contributor

morphis commented May 12, 2017

LGTM
@zyga
Merge branch 'master' of github.com:snapcore/snapd into writable-loca… 
…ltime

All checks have passed

8 successful checks
@mvo5
artful-amd64 — autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@mvo5
xenial-amd64 — autopkgtest finished (success)
Details
@mvo5
xenial-i386 — autopkgtest finished (success)
Details
@mvo5
xenial-ppc64el — autopkgtest finished (success)
Details
@mvo5
yakkety-amd64 — autopkgtest finished (success)
Details
@mvo5
zesty-amd64 — autopkgtest finished (success)
Details
a6901b6
@zyga

zyga approved these changes May 15, 2017
View changes

LGTM

@zyga zyga merged commit 429f3ec into master May 15, 2017
8 checks passed

8 checks passed

artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the writable-localtime branch May 15, 2017

@niemeyer
Contributor

niemeyer commented May 19, 2017

@zyga @ogra1 Please note our convention regarding summaries of pull requests and git commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment