Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
packaging: Add Fedora packaging files #3366
Conversation
Conan-Kudo
referenced this pull request
May 21, 2017
Merged
tests,packaging: add package build support for Fedora for our spread setup #3365
morphis
suggested changes
May 21, 2017
Please drop a6a328f as we can't merge that patch. We should just add the necessary bits for packaging/fedora-* and leave everything else as is.
|
@morphis It's dropped, but the packaging is effectively useless now, since it won't build. |
codecov-io
commented
May 21, 2017
Codecov Report
@@ Coverage Diff @@
## master #3366 +/- ##
=======================================
Coverage 77.55% 77.55%
=======================================
Files 366 366
Lines 25146 25146
=======================================
Hits 19501 19501
+ Misses 3897 3896 -1
- Partials 1748 1749 +1
Continue to review full report at Codecov.
|
| +set -e | ||
| + | ||
| +SNAP_MOUNT_DIR="/var/lib/snapd/snap" | ||
| +SNAP_UNIT_PREFIX="var-lib-snapd-snap" |
Thanks! See 67673a2 for a fix for the last patch we have in Fedora and not merged upstream yet. Actually the fixed LD script is only available in F26 so we need to fix this from the spec file to have a proper fix available for F24-F26. |
| @@ -0,0 +1 @@ | ||
| +fedora |
|
I'm merging this. Please iterate on subsequent changes. |
Conan-Kudo commentedMay 21, 2017
•
Edited 1 time
-
Conan-Kudo
May 21, 2017
This PR adds the packaging data for Fedora originating from the Fedora Dist-Git.
While the Fedora packaging in Dist-Git is the authoritative source, a copy of this in this repository will help enable spread testing.
Note the snapd package cannot be built without the patch from #3162.