Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: fix for the test postrm-purge #3448
Conversation
sergiocazzolato
added some commits
Jun 8, 2017
codecov-io
commented
Jun 8, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
==========================================
- Coverage 77.23% 77.22% -0.02%
==========================================
Files 373 373
Lines 25645 25645
==========================================
- Hits 19808 19805 -3
- Misses 4087 4089 +2
- Partials 1750 1751 +1
Continue to review full report at Codecov.
|
sergiocazzolato
added some commits
Jun 8, 2017
chipaca
approved these changes
Jun 8, 2017
Thank you for this!
As this fixes master, and only changes the tests, I think it's OK to land with just one +1.
One thing I'd like to point out is that we've discussed in the past that our git logs aren't very good, and we should try to improve them. One way I found that helped me visualise this, and then improve, is to run git log --oneline --no-merges (or, if you're feeling fancy, git log --pretty="format:%C(auto)%h %C(dim)%<(16,trunc)%an %C(nodim)%s" --no-merges). Also perhaps relevant is https://chris.beams.io/posts/git-commit/.
|
@chipaca thanks for pointing that, I'll work on this. |
sergiocazzolato commentedJun 8, 2017
•
Edited 1 time
-
sergiocazzolato
Jun 8, 2017
The fix is moves the clean up of the systemd service unit config files
to the reset.
This change will address the scenarios/tests where snapd is not in a
working state in the restore step.
Error fixing:
https://travis-ci.org/snapcore/snapd/builds/240775990