tests: fix for the test postrm-purge #3448

Merged
merged 5 commits into from Jun 9, 2017

Conversation

Projects
None yet
3 participants
Contributor

sergiocazzolato commented Jun 8, 2017

The fix is moves the clean up of the systemd service unit config files
to the reset.

This change will address the scenarios/tests where snapd is not in a
working state in the restore step.

Error fixing:
https://travis-ci.org/snapcore/snapd/builds/240775990

sergiocazzolato added some commits Jun 8, 2017

tests: fix for the test postrm-purge
The fix is moves the clean up of the systemd service unit config files
to the reset.

This change will address the scenarios/tests where snapd is not in a
working state in the restore step.

A new config.sh file is added which contains the configuration needed to
setup the system service units.

Error fixing:
https://travis-ci.org/snapcore/snapd/builds/240775990

codecov-io commented Jun 8, 2017

Codecov Report

Merging #3448 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3448      +/-   ##
==========================================
- Coverage   77.23%   77.22%   -0.02%     
==========================================
  Files         373      373              
  Lines       25645    25645              
==========================================
- Hits        19808    19805       -3     
- Misses       4087     4089       +2     
- Partials     1750     1751       +1
Impacted Files Coverage Δ
interfaces/sorting.go 90% <0%> (-6.67%) ⬇️
overlord/snapstate/snapstate.go 81.26% <0%> (-0.24%) ⬇️
cmd/snap/cmd_aliases.go 96% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4e95b5...358c0c6. Read the comment docs.

sergiocazzolato added some commits Jun 8, 2017

chipaca approved these changes Jun 8, 2017

Thank you for this!

As this fixes master, and only changes the tests, I think it's OK to land with just one +1.

One thing I'd like to point out is that we've discussed in the past that our git logs aren't very good, and we should try to improve them. One way I found that helped me visualise this, and then improve, is to run git log --oneline --no-merges (or, if you're feeling fancy, git log --pretty="format:%C(auto)%h %C(dim)%<(16,trunc)%an %C(nodim)%s" --no-merges). Also perhaps relevant is https://chris.beams.io/posts/git-commit/.

Contributor

sergiocazzolato commented Jun 8, 2017

@chipaca thanks for pointing that, I'll work on this.

@chipaca chipaca merged commit af68bd4 into snapcore:master Jun 9, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment