tests/main: check for confinement in a few more interface tests #3452

Merged
merged 2 commits into from Jun 12, 2017

Conversation

Projects
None yet
4 participants
Contributor

morphis commented Jun 9, 2017

No description provided.

+1 except for the content interface

tests/main/interfaces-content/task.yaml
@@ -31,6 +31,10 @@ execute: |
echo "And the current mount profile is the same as the desired mount profile"
diff -u /run/snapd/ns/snap.test-snapd-content-plug.fstab /var/lib/snapd/mount/snap.test-snapd-content-plug.fstab
+ if [ "$(snap debug confinement)" = none ]; then
@zyga

zyga Jun 9, 2017

Contributor

Hold on, the content interface uses mount backend so it should work everywhere. There is some apparmor too but it doesn't make it any less effective when we unmount things.

@morphis

morphis Jun 9, 2017

Contributor

Good spot, Thanks.

zyga approved these changes Jun 9, 2017

Codecov Report

Merging #3452 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
+ Coverage   77.26%   77.26%   +<.01%     
==========================================
  Files         373      373              
  Lines       25687    25687              
==========================================
+ Hits        19846    19848       +2     
+ Misses       4097     4095       -2     
  Partials     1744     1744
Impacted Files Coverage Δ
overlord/ifacestate/helpers.go 65.54% <0%> (ø) ⬆️
cmd/snap/cmd_aliases.go 96% <0%> (+2%) ⬆️
interfaces/sorting.go 96.66% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b5530...8e18f57. Read the comment docs.

mvo5 approved these changes Jun 12, 2017

@mvo5 mvo5 merged commit 3db0a57 into snapcore:master Jun 12, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment