interfaces/builtin: sync connected slot and permanent slot snippet #3470

Merged
merged 4 commits into from Jun 19, 2017

Conversation

Projects
None yet
6 participants
Contributor

morphis commented Jun 12, 2017

The connected plug snippet allows sending any method call from
a connected plug to the service but the corresponding snippet for
the slot denied receiving anything other than PropertiesChanged.

See https://forum.snapcraft.io/t/udisks2-interface-doesnt-allow-to-use-dbus-properties-interface/902
for more details.

Approved.

Note that I corrected the description of this PR.

Contributor

morphis commented Jun 12, 2017

@jdstrand Thanks!

interfaces/builtin: sync connected slot and permanent slot snippet
The connected slot snippet allows sending any method call from
a connected plug to the service but the same snippet for the
the slot denied receiving anything other than PropertiesChanged

See https://forum.snapcraft.io/t/udisks2-interface-doesnt-allow-to-use-dbus-properties-interface/902
for more details.

codecov-io commented Jun 12, 2017

Codecov Report

Merging #3470 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3470      +/-   ##
==========================================
- Coverage   77.16%   77.15%   -0.02%     
==========================================
  Files         373      373              
  Lines       25793    25793              
==========================================
- Hits        19904    19900       -4     
- Misses       4132     4135       +3     
- Partials     1757     1758       +1
Impacted Files Coverage Δ
interfaces/builtin/udisks2.go 82.5% <ø> (ø) ⬆️
interfaces/sorting.go 93.33% <0%> (-3.34%) ⬇️
cmd/snap/cmd_aliases.go 94% <0%> (-2%) ⬇️
overlord/snapstate/snapstate.go 81.28% <0%> (-0.24%) ⬇️
overlord/ifacestate/helpers.go 65.54% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1383502...e4d03d6. Read the comment docs.

mvo5 approved these changes Jun 13, 2017

Simon Fels added some commits Jun 13, 2017

zyga approved these changes Jun 19, 2017

+1

@zyga zyga merged commit 9de376f into snapcore:master Jun 19, 2017

6 of 7 checks passed

xenial-i386 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment