Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
store: change main store host to api.snapcraft.io #3475
Conversation
codecov-io
commented
Jun 13, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #3475 +/- ##
==========================================
+ Coverage 77.15% 77.15% +<.01%
==========================================
Files 373 375 +2
Lines 25793 25839 +46
==========================================
+ Hits 19901 19937 +36
- Misses 4134 4140 +6
- Partials 1758 1762 +4
Continue to review full report at Codecov.
|
pedronis
changed the title from
Change main store host to api.snapcraft.io
to
store: change main store host to api.snapcraft.io
Jun 15, 2017
pedronis
self-requested a review
Jun 20, 2017
| // FIXME: this will become a store-url assertion | ||
| - if u := os.Getenv("SNAPPY_FORCE_CPI_URL"); u != "" { | ||
| + // backward-compatibility: this used to be "Click Package Index" |
pedronis
Jun 20, 2017
Contributor
we probably want a TODO: or XXX: marker here, I suppose we'll drop this at some point
| - if u := os.Getenv("SNAPPY_FORCE_CPI_URL"); u != "" { | ||
| + // backward-compatibility: this used to be "Click Package Index" | ||
| + if u := os.Getenv("SNAPPY_FORCE_CPI_URL"); u != "" && strings.HasSuffix(u, "api/v1/") { | ||
| + return u[:len(u)-len("api/v1/")] |
added some commits
Jun 20, 2017
mvo5
merged commit f8f841f
into
snapcore:master
Jun 20, 2017
5 of 7 checks passed
artful-amd64
autopkgtest running
Details
zesty-amd64
autopkgtest running
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
cjwatson
deleted the
cjwatson:api-snapcraft-io
branch
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cjwatson commentedJun 13, 2017
•
Edited 1 time
-
cjwatson
Jun 16, 2017
As part of the enterprise store project, the store is moving over to
having a single api.snapcraft.io host which should eventually be the
front door for all queries from devices; this will make it much easier
to put something like an edge proxy in place, because only one URL will
need to be overridden.
At the moment, api.snapcraft.io only provides the non-legacy endpoints
that used to be part of Click Package Index, but it will soon be
expanded to provide others as well. This shifts snapd over to the new
host name. The older endpoints will of course be maintained for as long
as is necessary.
I've dropped the trailing
api/v1/from the URL, since we'll probablyhave a
v2/at some point but that may be on an endpoint-by-endpointbasis, so it doesn't make sense to pin all of snapd's API calls to the
same version.
The preferred way to set an alternate store API URL is now
SNAPPY_FORCE_API_URL=https://api.example.org/.SNAPPY_USE_STAGING_STORE=1still works as an abbreviated way to pointat staging.