tests: restart rng-tools services after few seconds #3494

Merged
merged 2 commits into from Jun 21, 2017

Conversation

Projects
None yet
4 participants
Contributor

sergiocazzolato commented Jun 20, 2017

Sometimes the service is not starting properly when it is restarted
inmediatly after the segfault. To deal with that it is recommended to
wait few seconds after the service is down to restart it.

Error:
https://travis-ci.org/snapcore/snapd/builds/244673127#L3493

tests: Restart rng-tools services after few seconds
Sometimes the service is not starting properly when it is restarted
inmediatly after the segfault. To deal with that it is recommended to
wait few seconds after the service is down to restart it.

Error:
https://travis-ci.org/snapcore/snapd/builds/244673127#L3493

mvo5 approved these changes Jun 20, 2017

👍 if it helps.

@pedronis pedronis changed the title from tests: Restart rng-tools services after few seconds to tests: restart rng-tools services after few seconds Jun 20, 2017

Adding sleep to create key to avoid see the password on the screen
The pass is shown like this:

+ echo 'Creating a new key without a password'
Creating a new key without a password
+ expect -f create-key.exp
spawn snap create-key
Passphrase: pass
Confirm passphrase:
<kill-timeout reached>

Error:
https://travis-ci.org/snapcore/snapd/builds/244684797#L3433

Codecov Report

Merging #3494 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   77.18%   77.18%   +<.01%     
==========================================
  Files         375      377       +2     
  Lines       25837    25881      +44     
==========================================
+ Hits        19941    19977      +36     
- Misses       4136     4141       +5     
- Partials     1760     1763       +3
Impacted Files Coverage Δ
overlord/hookstate/hookmgr.go 65.58% <0%> (-2.48%) ⬇️
cmd/snap/cmd_aliases.go 94% <0%> (-2%) ⬇️
overlord/overlord.go 80.24% <0%> (-0.77%) ⬇️
store/store.go 79.44% <0%> (-0.18%) ⬇️
overlord/cmdstate/cmdmgr.go 92% <0%> (ø)
overlord/cmdstate/cmdstate.go 100% <0%> (ø)
interfaces/sorting.go 96.66% <0%> (+3.33%) ⬆️
osutil/exec.go 73.83% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33e542...49adc2b. Read the comment docs.

@chipaca chipaca merged commit a35fb0f into snapcore:master Jun 21, 2017

6 of 7 checks passed

yakkety-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment