Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
add broadcom-asic-control interface #3615
Conversation
Some checks were not successful
morphis
commented on interfaces/builtin/broadcom-asic-control.go in b72277e
Jul 24, 2017
|
allows -> Allows |
morphis
replied
Jul 24, 2017
|
broadcom-asic -> Broadcom ASIC |
morphis
commented on interfaces/builtin/broadcom-asic-control.go in b72277e
Jul 24, 2017
|
Why only "sometimes write"? The interface either gives read or write access but there is nothing in between. "broadcom asic" -> Broadcom ASIC |
morphis
commented on interfaces/builtin/broadcom-asic-control.go in b72277e
Jul 24, 2017
|
broadcom asic -> Broadcom ASIC |
| + | ||
| +const broadcomAsicControlSummary = `allows using the broadcom-asic kernel module` | ||
| + | ||
| +const broadcomAsicControlDescription = ` |
zyga
Jul 24, 2017
Contributor
Description is now out. Please open a thread on the forum, document the interface there and add a documentation link (I will try to land the related branch today so that you can do this).
| +const broadcomAsicControlConnectedPlugAppArmor = ` | ||
| +# Description: Allow access to broadcom asic kernel module. | ||
| + | ||
| +/sys/module/linux_kernel_bde/initstate r, |
zyga
Jul 24, 2017
Contributor
Is it necessary to load any modules for this interface to work? Does the required module automatically load by itself? Snapd has a kmod backend where connected interface can trigger a module load without empowering the application process to load arbitrary modules.
| +/sys/module/linux_bcm_knet/initstate r, | ||
| +/sys/module/linux_bcm_knet/holders/ r, | ||
| +/sys/module/linux_bcm_knet/refcnt r, | ||
| +/dev/linux-user-bde rw, |
zyga
Jul 24, 2017
Contributor
I think those need to be tagged and added via the udev backend as well.
|
@zyga Thanks for the comments. As @knitzsche is out this week I will take this over and open another PR soon with your comments fixed.
Are there already any examples for this? Which PR you're referring to? |
|
Closing as requested by morphis in #3615 (comment) |
knitzsche commentedJul 21, 2017
provide an apparmor snippet that grants access to the files associated with the broadcom asic kernel module.