Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces/builtin: discard empty Validate{Plug,Slot} #3620
Conversation
codecov-io
commented
Jul 25, 2017
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
==========================================
+ Coverage 75.01% 75.09% +0.08%
==========================================
Files 383 383
Lines 33208 33176 -32
==========================================
+ Hits 24910 24913 +3
+ Misses 6494 6459 -35
Partials 1804 1804
Continue to review full report at Codecov.
|
zyga
merged commit dca893e
into
snapcore:master
Jul 26, 2017
7 checks passed
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:tweak/drop-empty-validate-methods
branch
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedJul 25, 2017
The validate methods used to be mandatory but they are entirely optional
now and can be safely discarded.
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com