tests: fix refresh tests not stopping fake store for fedora #3629

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
4 participants
Contributor

sergiocazzolato commented Jul 26, 2017

Removing code to avoid stopping the fake store for fedora in refresh
task and adding sanity check before set the refresh

Error:
https://travis-ci.org/snapcore/snapd/builds/257633119

tests: fix refresh tests not stopping fake store for fedora
Removing code to svoid stopping the fake store for fedora in refresh
task and adding sanity check before set the refresh

Error:
https://travis-ci.org/snapcore/snapd/builds/257633119

Codecov Report

Merging #3629 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3629      +/-   ##
==========================================
- Coverage   75.21%   75.21%   -0.01%     
==========================================
  Files         384      384              
  Lines       33538    33538              
==========================================
- Hits        25226    25224       -2     
- Misses       6491     6493       +2     
  Partials     1821     1821
Impacted Files Coverage Δ
interfaces/sorting.go 97.43% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf28721...1a5c50c. Read the comment docs.

zyga approved these changes Jul 26, 2017

Looks good, thanks! +1

cachio_: I'm finding these prepare and restore in the refresh test pretty hard to follow
17:26:21 cachio_: There are so many exit points.. pretty hard to track what is actually happening there
cachio_: Your changes are minor, so if they fix the problem, LGTM
17:27:23 cachio_: But it would be good to clean that up at some point

@sergiocazzolato sergiocazzolato merged commit 90092db into snapcore:master Jul 26, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment