Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: fix refresh tests not stopping fake store for fedora #3629
Conversation
codecov-io
commented
Jul 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #3629 +/- ##
==========================================
- Coverage 75.21% 75.21% -0.01%
==========================================
Files 384 384
Lines 33538 33538
==========================================
- Hits 25226 25224 -2
- Misses 6491 6493 +2
Partials 1821 1821
Continue to review full report at Codecov.
|
niemeyer
approved these changes
Jul 26, 2017
cachio_: I'm finding these prepare and restore in the refresh test pretty hard to follow
17:26:21 cachio_: There are so many exit points.. pretty hard to track what is actually happening there
cachio_: Your changes are minor, so if they fix the problem, LGTM
17:27:23 cachio_: But it would be good to clean that up at some point
sergiocazzolato commentedJul 26, 2017
•
Edited 1 time
-
zyga
Jul 26, 2017
Removing code to avoid stopping the fake store for fedora in refresh
task and adding sanity check before set the refresh
Error:
https://travis-ci.org/snapcore/snapd/builds/257633119