release: remove default from VERSION_ID #3648

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Aug 2, 2017

According to os-release(5) there is no default value for this field so
we should not provide one. This also removes the unexpected "unknown"
element from "snap version" on rolling releases, such as Arch.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

release: remove default from VERSION_ID
According to os-release(5) there is no default value for this field so
we should not provide one. This also removes the unexpected "unknown"
element from "snap version" on rolling releases, such as Arch.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

Codecov Report

Merging #3648 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3648      +/-   ##
==========================================
+ Coverage    75.2%   75.21%   +<.01%     
==========================================
  Files         387      387              
  Lines       33452    33451       -1     
==========================================
+ Hits        25159    25160       +1     
+ Misses       6481     6479       -2     
  Partials     1812     1812
Impacted Files Coverage Δ
release/release.go 89.18% <ø> (-0.15%) ⬇️
overlord/ifacestate/helpers.go 63% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e037060...81bd765. Read the comment docs.

mvo5 approved these changes Aug 7, 2017

@mvo5 mvo5 added this to the 2.27 milestone Aug 7, 2017

@zyga zyga merged commit 61d3ead into snapcore:master Aug 7, 2017

6 of 7 checks passed

yakkety-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:fix/release-unknown branch Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment