Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
release: remove default from VERSION_ID #3648
Conversation
codecov-io
commented
Aug 2, 2017
Codecov Report
@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
+ Coverage 75.2% 75.21% +<.01%
==========================================
Files 387 387
Lines 33452 33451 -1
==========================================
+ Hits 25159 25160 +1
+ Misses 6481 6479 -2
Partials 1812 1812
Continue to review full report at Codecov.
|
mvo5
added this to the 2.27 milestone
Aug 7, 2017
zyga
merged commit 61d3ead
into
snapcore:master
Aug 7, 2017
6 of 7 checks passed
yakkety-amd64
autopkgtest finished (failure)
Details
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:fix/release-unknown
branch
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedAug 2, 2017
According to os-release(5) there is no default value for this field so
we should not provide one. This also removes the unexpected "unknown"
element from "snap version" on rolling releases, such as Arch.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl